Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity registry api update disable #26015

Merged
merged 5 commits into from Aug 16, 2019

Conversation

@balloob
Copy link
Member

commented Aug 16, 2019

Description:

Allow changing disabled_by for entities in the entity registry. This is in preparation of adding a UI for managing disabled entities in the entity registry.

Also migrated entity registry WS commands to the modern format.

Part of home-assistant/architecture#276

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Aug 16, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 16, 2019

@Kane610
Copy link
Contributor

left a comment

Looks good to me!

tests/components/config/test_entity_registry.py Outdated Show resolved Hide resolved

Dev automation moved this from Needs review to Reviewer approved Aug 16, 2019

balloob and others added 2 commits Aug 16, 2019
Update tests/components/config/test_entity_registry.py
Co-Authored-By: Robert Svensson <Kane610@users.noreply.github.com>

@balloob balloob merged commit eba6caf into dev Aug 16, 2019

4 of 5 checks passed

CI Build #20190816.70 failed
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Aug 16, 2019

@delete-merged-branch delete-merged-branch bot deleted the entity-registry-api-update-disable branch Aug 16, 2019

@lock lock bot locked and limited conversation to collaborators Aug 17, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.