Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone down huawei_lte logging #26020

Merged
merged 2 commits into from Aug 17, 2019

Conversation

@scop
Copy link
Contributor

commented Aug 17, 2019

Description:

Do not output tracebacks for expected "not supported" exceptions, handle missing wlan_host_list data more gracefully, log missing data values on debug level.

Makes the experience smoother especially with USB modem sticks, quite probably other devices with no requested data.

Related issue (if applicable): #23809

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@MartinHjelmare
Copy link
Member

left a comment

Looks good!

Dev automation moved this from Needs review to Reviewer approved Aug 17, 2019

@scop scop merged commit 9dff2e1 into home-assistant:dev Aug 17, 2019

9 checks passed

CI Build #20190817.19 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Aug 17, 2019

@scop scop deleted the scop:huawei-lte-logging branch Aug 17, 2019

@lock lock bot locked and limited conversation to collaborators Aug 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.