Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove reference to typing.Deque (added in Python 3.6.1) #26030
The setup script claims a minimum Python version of 3.6.0, but when I run with Python 3.6.0 it chokes on an import of
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
If the code does not interact with devices:
Side note: should make sure our test and dev environments correspond to what we say the minimum version is. So if it's 3.6.0, need to develop and test with that, not (only) e.g. 3.6.9. Will fix up my local pyenv now, and have a look at what can be done to the CI setups.
@scop judging by the different responses to your two PRs, it looks like there's some disagreement as to whether this is even an issue. Either you're right, and the test environments should be updated to use the minimum required version, or the minimum required version should bump every time a new Python bugfix release introduces a new API.
I'd love to get a definitive stance on that. I know in the past I've avoided using APIs if I noticed they had been introduced in a bugfix release, and when I set up my latest development environment I deliberately put 3.6.0 in my venv so that it would catch that kind of thing. If I'm allowed to develop for 3.6.9 I'll gladly do so.
I imagine this PR isn't the right place to hash this out though... where is?