Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to typing.Deque (added in Python 3.6.1) #26030

Merged
merged 3 commits into from Aug 19, 2019

Conversation

@jkeljo
Copy link
Contributor

commented Aug 17, 2019

Description:

The setup script claims a minimum Python version of 3.6.0, but when I run with Python 3.6.0 it chokes on an import of Deque from the typing module, since that was added in 3.6.1. This PR removes the import.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from scop Aug 18, 2019

scop added a commit to scop/home-assistant that referenced this pull request Aug 18, 2019

Dev automation moved this from Needs review to Review in progress Aug 18, 2019

homeassistant/components/camera/__init__.py Outdated Show resolved Hide resolved
@scop

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

Side note: should make sure our test and dev environments correspond to what we say the minimum version is. So if it's 3.6.0, need to develop and test with that, not (only) e.g. 3.6.9. Will fix up my local pyenv now, and have a look at what can be done to the CI setups.

scop added a commit to scop/home-assistant that referenced this pull request Aug 18, 2019
scop added a commit to scop/ci-azure that referenced this pull request Aug 18, 2019
@scop scop referenced this pull request Aug 18, 2019
scop added a commit to scop/home-assistant that referenced this pull request Aug 18, 2019
scop added a commit to scop/home-assistant that referenced this pull request Aug 18, 2019
@scop scop referenced this pull request Aug 18, 2019
1 of 1 task complete
@jkeljo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

@scop judging by the different responses to your two PRs, it looks like there's some disagreement as to whether this is even an issue. Either you're right, and the test environments should be updated to use the minimum required version, or the minimum required version should bump every time a new Python bugfix release introduces a new API.

I'd love to get a definitive stance on that. I know in the past I've avoided using APIs if I noticed they had been introduced in a bugfix release, and when I set up my latest development environment I deliberately put 3.6.0 in my venv so that it would catch that kind of thing. If I'm allowed to develop for 3.6.9 I'll gladly do so.

I imagine this PR isn't the right place to hash this out though... where is?

@scop scop self-requested a review Aug 19, 2019

@scop
scop approved these changes Aug 19, 2019

Dev automation moved this from Review in progress to Reviewer approved Aug 19, 2019

@scop

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

Looks good, approved assuming CI will start to pass once the seemingly unrelated issues (e.g. #26060) are fixed (can't merge before they pass it seems). Also filed home-assistant/architecture#278 to get the micro version issue sorted out.

@scop scop merged commit a38bdc4 into home-assistant:dev Aug 19, 2019

11 checks passed

CI Build #20190819.4 had test failures
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 9dff2e1...d02baac
Details
codecov/project 94.02% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 19, 2019

@lock lock bot locked and limited conversation to collaborators Aug 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.