Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sisyphus-control to 2.2.1 #26033

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@jkeljo
Copy link
Contributor

commented Aug 18, 2019

Description:

This picks up a bugfix for a crash on shutdown, so that the sisyphus
component can now shut down cleanly.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Upgrade sisyphus-control to 2.2.1
This picks up a bugfix for a crash on shutdown, so that the `sisyphus`
component can now shut down cleanly.

Dev automation moved this from Needs review to Reviewer approved Aug 18, 2019

@andrewsayre

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

Test failure seems unrelated, but try rebasing.

Dev automation moved this from Reviewer approved to Cancelled Aug 18, 2019

@andrewsayre andrewsayre reopened this Aug 18, 2019

Dev automation moved this from Cancelled to Needs review Aug 18, 2019

@balloob balloob merged commit 65aa414 into home-assistant:dev Aug 18, 2019

13 checks passed

CI Build #20190818.8 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing fed789c...1fae18d
Details
codecov/project 94.03% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Needs review to Done Aug 18, 2019

@lock lock bot locked and limited conversation to collaborators Aug 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.