Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add new integration for Jandy iAqualink pool control #26034
This is a new component introducing support for Jandy iAqualink pool controls.
This PR includes support for the climate platform only.
If the code communicates with devices, web services, or third-party tools:
MartinHjelmare left a comment
Thanks for the PR. Please start by removing the light, sensor and switch platforms from this PR. More platforms can come in later PRs, one platform per PR. We want PRs as small as possible for quicker merge.
Thanks for the review.
Please update the documentation to reflect that new integrations shouldn't contain more than a single platform for the reasons you mention. I understand the goal of making PR somewhat self-contained but in the case of a new integration, this seems rather arbitrary, especially when undocumented.
The docs do indicate that, but please let us know how we could make it more clear -- or better yet, submit a PR to the docs themselves with your improvements. :)