Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the googlehome integration #26035

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@ludeeus
Copy link
Contributor

commented Aug 18, 2019

Breaking Change:

The googlehome integration has been removed.

For a couple of weeks/months this integration was broken when google change the port they serve this information on, and to require a token header in the request.

That method requires the user to have a rooted android, and even then then the "result" was not the best, since you often need to get that token.

As an alternative to the device tracker, users can look into https://community.home-assistant.io/t/monitor-reliable-multi-user-distributed-bluetooth-occupancy-presence-detection/68505

Description:

For the alarm sensor, I'm not aware of any alternatives.

Related issue (if applicable):

closes #25673 closes #24815 closes #24013 closes #21357 closes #21315

Pull request with documentation for home-assistant.io: home-assistant/home-assistant.io#10166

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Aug 18, 2019

@ludeeus ludeeus referenced this pull request Aug 18, 2019
2 of 2 tasks complete

@ludeeus ludeeus marked this pull request as ready for review Aug 18, 2019

TychoWerner added a commit to TychoWerner/home-assistant.io that referenced this pull request Aug 18, 2019
Added warning for integration getting removed
The googlehome integration is getting removed so letting users know when they wish to setup they know it's going away according to this pull: home-assistant/home-assistant#26035

Dev automation moved this from Needs review to Reviewer approved Aug 18, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

I would include the three first paragraphs of the description in the breaking change notes, to give the user some more info.

@ludeeus

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2019

Just including it looked a bit redundant, so I moved it :)

@Leatherface75

This comment has been minimized.

Copy link

commented Aug 18, 2019

Google Home integration works for me with this https://github.com/Drakulix/ghlapi_proxy & android install in virtual machine there i have a crontab that grabs homegraph file.
Rooted phone works too but better to use a virtual machine.
Not perfect and i have to restart Home app sometimes but atleast works.
Removing this would make that not working either.
What i also found out is that when it stops working in HA it doesn't work in Google's own app either and that's why i have to restart it sometimes before it works again so even their own app have problems. After that my crontab gets the working tokens again and it works in both Home app and HA again. Trying to fix that last problem with Tasker for automatic restarting of app.

What i think the Home app does is requesting this or similar command when running app and that gets informations of all devices in Google Home.
https://developers.google.com/actions/smarthome/reference/rest/v1/devices/sync

Token for that API you already have in Google Assistant integration.

I hope you can find a solution for this without need for all that but it's atleast possible for now with little work.
That alternatives would mean i need to buy more hardware and have in every room so that's not en alternative for me and would only work for presence detection.
Also i am trying to get that working in my computer room there i don't have any google home device but that solution only gives me.

hcitool lescan
Set scan parameters failed: Input/output error

Suggestions to restart and all that doesn't work either.

fabaff added a commit to home-assistant/home-assistant.io that referenced this pull request Aug 20, 2019
Added warning for integration getting removed (#10168)
* Added warning for integration getting removed

The googlehome integration is getting removed so letting users know when they wish to setup they know it's going away according to this pull: home-assistant/home-assistant#26035

* ✏️ Tweak
@balloob

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

@Leatherface75 feel free to continue using this integration as a custom component. It is too much hassle to use to be part of the Home Assistant core.

@balloob balloob merged commit d96edea into home-assistant:dev Aug 20, 2019

12 checks passed

CI Build #20190818.14 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing a2589f5...49876a8
Details
codecov/project 94.02% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 20, 2019

@Leatherface75

This comment has been minimized.

Copy link

commented Aug 20, 2019

How do i use this as custom component?
(I know how to use custom component but how do i use an internal component as custom component?)
And still this should be possible to get working in the way i mentioned above and that's the way google assistant component is getting information from homegraph API. Same API as Google Home uses.

@lock lock bot locked and limited conversation to collaborators Aug 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
6 participants
You can’t perform that action at this time.