Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZHA siren and warning device support #26046

Merged
merged 9 commits into from Sep 20, 2019

Conversation

@dmulcahey
Copy link
Contributor

commented Aug 18, 2019

Description:

This PR implements the IAS warning device channel and exposes services to interact with its commands that can be leveraged in automations.

Related issue (if applicable): fixes #25315

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@probot-home-assistant

This comment has been minimized.

Copy link

commented Aug 18, 2019

Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Aug 18, 2019
@dmulcahey dmulcahey force-pushed the dmulcahey:dm/zha-warning-device-support branch from 2288cee to 155b9c0 Aug 27, 2019
@dmulcahey dmulcahey force-pushed the dmulcahey:dm/zha-warning-device-support branch from 8749145 to cef6add Sep 16, 2019
dmulcahey added 8 commits Aug 18, 2019
@dmulcahey dmulcahey force-pushed the dmulcahey:dm/zha-warning-device-support branch from b7af53b to 253d307 Sep 20, 2019
@dmulcahey dmulcahey changed the title WIP - ZHA siren and warning device support ZHA siren and warning device support Sep 20, 2019
@dmulcahey dmulcahey marked this pull request as ready for review Sep 20, 2019
@Adminiuga

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

Is it better to log the error and throw an exception? At least when calling the service from UI you gonna see notification about failed service call.

@jgirardet

This comment has been minimized.

Copy link

commented Sep 20, 2019

Hi,
I have a zigbee siren (HS2WD) and I 'd like to test this PR but I'm not sure what is the way to do it.
I can't see it in contributing.md

Copy link
Contributor

left a comment

Looks good!

Dev automation moved this from Incoming to Reviewer approved Sep 20, 2019
@Adminiuga Adminiuga merged commit 62adff2 into home-assistant:dev Sep 20, 2019
11 checks passed
11 checks passed
CI Build #20190920.21 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project 94.04% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 20, 2019
KJonline added a commit to KJonline/home-assistant that referenced this pull request Sep 20, 2019
* dev: (167 commits)
  Bump aiowwlln to 2.0.2 (home-assistant#26769)
  ZHA siren and warning device support (home-assistant#26046)
  Add transport data from maps.yandex.ru api (home-assistant#26766)
  Type hint additions (home-assistant#26765)
  Bump openwrt-luci-rpc to version 1.1.1 (home-assistant#26759)
  Revert "Add transport data from maps.yandex.ru api (home-assistant#26252)" (home-assistant#26762)
  [ci skip] Translation update
  Updated frontend to 20190919.0
  deCONZ improve gateway tests (home-assistant#26709)
  Add transport data from maps.yandex.ru api (home-assistant#26252)
  Update codeowners (home-assistant#26733)
  Bump influxdb to 5.2.3 (home-assistant#26743)
  Izone component (home-assistant#24550)
  Bump restrictedpython to 5.0 (home-assistant#26741)
  Bumped version to 0.99.1
  Add Plex config flow support (home-assistant#26548)
  Bump pyobihai to fix issue with user account (home-assistant#26736)
  Bump TRADFRI (home-assistant#26731)
  Encode prometheus metric names per the prom spec (home-assistant#26639)
  Bump aiohttp to 3.6.1 (home-assistant#26739)
  ...
KJonline added a commit to KJonline/home-assistant that referenced this pull request Sep 21, 2019
* dev: (92 commits)
  Bump pynws version to 0.8.1 (home-assistant#26770)
  Bump HAP-python to 2.6.0 for homekit (home-assistant#26783)
  [ci skip] Translation update
  Add integration scaffolding script (home-assistant#26777)
  Bump simplisafe-python to 5.0.1 (home-assistant#26775)
  Bump aiowwlln to 2.0.2 (home-assistant#26769)
  ZHA siren and warning device support (home-assistant#26046)
  Add transport data from maps.yandex.ru api (home-assistant#26766)
  Type hint additions (home-assistant#26765)
  Bump openwrt-luci-rpc to version 1.1.1 (home-assistant#26759)
  Revert "Add transport data from maps.yandex.ru api (home-assistant#26252)" (home-assistant#26762)
  [ci skip] Translation update
  Updated frontend to 20190919.0
  deCONZ improve gateway tests (home-assistant#26709)
  Add transport data from maps.yandex.ru api (home-assistant#26252)
  Update codeowners (home-assistant#26733)
  Bump influxdb to 5.2.3 (home-assistant#26743)
  Izone component (home-assistant#24550)
  Bump restrictedpython to 5.0 (home-assistant#26741)
  Bumped version to 0.99.1
  ...
@lock lock bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.