Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure config flows extend ConfigFlow base class #26051

merged 1 commit into from Aug 18, 2019


Copy link

commented Aug 18, 2019


With the introduction of config options we assumed all config flow handlers extend ConfigFlow, as per the docs. This was not the case for 3 config flows. This fixes it.

Thinking about writing a hassfest validator later.


This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2019

Going to yolo merge this as it unbreaks dev.

@balloob balloob merged commit 3463cc9 into dev Aug 18, 2019

5 of 6 checks passed

CI Build #20190818.47 failed
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.

Dev automation moved this from Needs review to Done Aug 18, 2019

@delete-merged-branch delete-merged-branch bot deleted the extend-config-flow branch Aug 18, 2019

@lock lock bot locked and limited conversation to collaborators Aug 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
You can’t perform that action at this time.