Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #26052

merged 3 commits into from Aug 19, 2019


Copy link

commented Aug 18, 2019

Change regexp to cope with out of range values, ie "rssi" : ">=-51dBm".

Breaking Change:


Related issue (if applicable): fixes #

Pull request with documentation for (if applicable): home-assistant/< PR number goes here>

Example entry for configuration.yaml (if applicable):


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Change regexp to cope with out of range values, ie "rssi" : ">=-51dBm".

@flebourse flebourse requested a review from scop as a code owner Aug 18, 2019


This comment has been minimized.

Copy link

commented Aug 18, 2019

Hi @flebourse,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.



This comment has been minimized.

Copy link

commented Aug 19, 2019

Formatting check by black fails, be sure to set up the dev environment, it installs a pre-commit hook that would have caught this:

I'll have a look at doing this for you now, as well as adding some related tests.

scop added 2 commits Aug 19, 2019

@scop scop merged commit 45aec2e into home-assistant:dev Aug 19, 2019

9 checks passed

CI Build #20190819.41 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Needs review to Done Aug 19, 2019

@lock lock bot locked and limited conversation to collaborators Aug 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.