Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong exposed light for emulated hue #26055

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@croghostrider
Copy link
Contributor

commented Aug 18, 2019

Breaking Change:

A light without brightness support which was discovered before this PR will not be recognized more.
The old light has to be deleted over the web interface or the app from Alexa.
After this Tell Alexa: Alexa, discover my devices and the light without brightness support should be found.

Description:

All lights without brightness support, generate errors in the Alexa app.
When a lamp is switched on via voice control Alexa responds Light isn’t responding but the light turns on and the app shows Device doesn't support requested value.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
check if a light supports brightness
Fix black

Fix black

@croghostrider croghostrider force-pushed the croghostrider:Fix-exposed-light branch from 5743e90 to 8c8ad3c Aug 19, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

The history of this PR…

This was initially introduced in #24467, caused #25645 and so got reverted in #25732.

The breaking change description seems to describe exactly what @grantclem did in #25645 but that did not work. @grantclem will you be able to test this PR?

This PR fixes #25047.

@grantclem

This comment has been minimized.

Copy link

commented Aug 21, 2019

Happy to do more testing during the 0.98 beta phase.

Dev automation moved this from Needs review to Reviewer approved Aug 21, 2019

@balloob balloob merged commit 08d797e into home-assistant:dev Aug 21, 2019

11 checks passed

CI Build #20190819.52 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.02%)
Details
codecov/project 94.02% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 21, 2019

@Birdbrainuk

This comment has been minimized.

Copy link

commented Aug 21, 2019

This all sounds promising. Do I just need to wait for release 0.98 for this fix.

@lock lock bot locked and limited conversation to collaborators Aug 22, 2019

@croghostrider croghostrider deleted the croghostrider:Fix-exposed-light branch Sep 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5 participants
You can’t perform that action at this time.