Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alarm webhooks for Point #26062

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@fredrike
Copy link
Contributor

commented Aug 19, 2019

Description:

Fixes an logical error for the alarm triggered webhook.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Dev automation moved this from Needs review to Review in progress Aug 19, 2019

Dev automation moved this from Review in progress to Reviewer approved Aug 19, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Please rebase on latest dev branch to let the build pass.

@fredrike fredrike force-pushed the fredrike:point-alarm branch from b97285e to bc462e4 Aug 19, 2019

@pvizeli pvizeli merged commit 15ab004 into home-assistant:dev Aug 19, 2019

11 checks passed

CI Build #20190819.23 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 6b80df9...bc462e4
Details
codecov/project 94.02% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 19, 2019

@lock lock bot locked and limited conversation to collaborators Aug 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.