Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save config entry after updating system options #26077

merged 1 commit into from Aug 19, 2019


Copy link

commented Aug 19, 2019


Small oversight when we added system options, we didn't save them! This routes the updating of system options through the async_update_entry call which correctly triggers a save.

CC @Kane610

@balloob balloob requested a review from home-assistant/core as a code owner Aug 19, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 19, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 19, 2019

@andrewsayre andrewsayre merged commit a1dbdbb into dev Aug 19, 2019

10 checks passed

CI Build #20190819.58 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 19, 2019

@delete-merged-branch delete-merged-branch bot deleted the save-entry-update-system-options branch Aug 19, 2019

@lock lock bot locked and limited conversation to collaborators Aug 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.