Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump geniushub client #26084

Merged
merged 3 commits into from Aug 20, 2019

Conversation

@zxdavb
Copy link
Contributor

commented Aug 20, 2019

Breaking Change:

None known.

Description:

Bumps client to latest version (minor bug fixes, refactor).
Adds type hints
De-linting.

Related issue (if applicable): fixes N/A

Pull request with documentation for home-assistant.io (if applicable): N?A

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
zxdavb added 3 commits Aug 20, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 20, 2019

@zxdavb zxdavb requested a review from MartinHjelmare Aug 20, 2019

@zxdavb zxdavb moved this from Needs review to Incoming in Dev Aug 20, 2019

@zxdavb zxdavb moved this from Incoming to Needs review in Dev Aug 20, 2019

@zxdavb zxdavb marked this pull request as ready for review Aug 20, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 20, 2019

@balloob balloob merged commit 33c35a6 into home-assistant:dev Aug 20, 2019

12 checks passed

CI Build #20190820.14 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing c5ca431...c0cfb58
Details
codecov/project 94% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 20, 2019

@zxdavb zxdavb deleted the zxdavb:bump_geniushub_client branch Aug 20, 2019

@lock lock bot locked and limited conversation to collaborators Aug 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.