Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker ADR #26085

Merged
merged 8 commits into from Aug 20, 2019

Conversation

@pvizeli
Copy link
Member

commented Aug 20, 2019

Implement https://github.com/home-assistant/architecture/blob/master/adr/0006-docker-images.md

Note: I removed the vagrant because they run with python35 and look like there is no maintainer around. I think also we should have such stuff, not in the main repository.

@pvizeli pvizeli requested a review from Aug 20, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 20, 2019

@pvizeli pvizeli force-pushed the docker-ADR branch from a311aa3 to 880ca90 Aug 20, 2019

@frenck
frenck approved these changes Aug 20, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 20, 2019

@frenck

This comment was marked as outdated.

Copy link
Member

commented Aug 20, 2019

LGTM

azure-pipelines-release.yml Outdated Show resolved Hide resolved
@frenck
Copy link
Member

left a comment

Architectures for manifest must match those from GO:

https://golang.org/doc/install/source#environment

So we have incorrect ones now. Use variants for specific CPU's

Dev automation moved this from Reviewer approved to Review in progress Aug 20, 2019

@frenck
frenck approved these changes Aug 20, 2019

Dev automation moved this from Review in progress to Reviewer approved Aug 20, 2019

@pvizeli pvizeli requested a review from balloob Aug 20, 2019

@@ -1,64 +0,0 @@
# Dockerfile for development

This comment has been minimized.

Copy link
@balloob

balloob Aug 20, 2019

Member

Let's keep a dev dockerfile. Not everyone using VSCode with dev containers yet :)

pvizeli added 8 commits Aug 20, 2019

@pvizeli pvizeli force-pushed the docker-ADR branch from 6fa0773 to db8177d Aug 20, 2019

@balloob balloob merged commit 97d3f49 into dev Aug 20, 2019

11 checks passed

CI Build #20190820.29 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 178d0d2...db8177d
Details
codecov/project 94% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 20, 2019

@delete-merged-branch delete-merged-branch bot deleted the docker-ADR branch Aug 20, 2019

@lock lock bot locked and limited conversation to collaborators Aug 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.