Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pylacrosse library to version 0.4.0 #26088

Merged
merged 2 commits into from Aug 20, 2019

Conversation

@legacycode
Copy link
Contributor

commented Aug 20, 2019

This PR just updates the pylacrosse library to version 0.4.0.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Hi @legacycode,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@project-bot project-bot bot added this to Needs review in Dev Aug 20, 2019

@homeassistant homeassistant added cla-signed and removed cla-needed labels Aug 20, 2019

@MartinHjelmare
Copy link
Member

left a comment

Please run script/gen_requirements_all.py and commit the changes.

Dev automation moved this from Needs review to Review in progress Aug 20, 2019

@MartinHjelmare MartinHjelmare changed the title Updated pylacrosse library to version 0.4.0. Adding support for remot… Update pylacrosse library to version 0.4.0 Aug 20, 2019

@balloob balloob merged commit daa0330 into home-assistant:dev Aug 20, 2019

11 checks passed

CI Build #20190820.32 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing c5ca431...af2ba7d
Details
codecov/project 94% (target 90%)
Details

Dev automation moved this from Review in progress to Done Aug 20, 2019

@lock lock bot locked and limited conversation to collaborators Aug 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.