Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open-ui cli arg #26091

Merged
merged 2 commits into from Aug 20, 2019

Conversation

@balloob
Copy link
Member

commented Aug 20, 2019

Description:

The open UI cli arg didn't work because it would attach the listener for START event after the event got fired. This fixes it. When we refactored this code, all set up was done before we get to the check so we can just add_job it.

@balloob balloob requested a review from home-assistant/core as a code owner Aug 20, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 20, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 20, 2019

@pvizeli pvizeli merged commit 5c91a6c into dev Aug 20, 2019

11 checks passed

CI Build #20190820.35 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 0e45042...b08bdd8
Details
codecov/project 94% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 20, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-open-ui branch Aug 20, 2019

@lock lock bot locked and limited conversation to collaborators Aug 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.