Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ruamel_yaml to 0.15.100 #26095

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@BKPepe
Copy link
Contributor

commented Aug 20, 2019

Description:

From https://pypi.org/project/ruamel.yaml/

0.15.100 (2019-07-17):
fixing issue with dumping deep-copied data from commented YAML, by providing both the memo parameter to deepcopy, and by allowing startmarks to be compared on their content (reported by Theofilos Petsios)

Maybe it will be useful to update it to 0.16.x?

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

@BKPepe BKPepe requested a review from home-assistant/core as a code owner Aug 20, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 20, 2019

@andrewsayre

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Maybe it will be useful to update it to 0.16.x?

Feel free to update it to the latest and run the tests and fix the code as necessary. If it breaks anything, we can discuss the impact and whether to proceed.

@balloob
Copy link
Member

left a comment

Let's merge this as-is, you can open a new PR for 16.

Dev automation moved this from Needs review to Reviewer approved Aug 21, 2019

@balloob balloob merged commit 39d62b4 into home-assistant:dev Aug 21, 2019

12 checks passed

CI Build #20190820.41 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 5c91a6c...465eafb
Details
codecov/project 94% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 21, 2019

@BKPepe BKPepe deleted the BKPepe:ruamelyaml branch Aug 21, 2019

@lock lock bot locked and limited conversation to collaborators Aug 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.