Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bimmer_connected to 0.6.0 #26098

Merged
merged 2 commits into from Aug 21, 2019

Conversation

@gerard33
Copy link
Contributor

commented Aug 20, 2019

Description:

Update bimmer_connected to 0.6.0 which has the following changes:

  • Add OPEN_TILT to LidState for sunroof
  • Clarify error messages in case no connection to the BMW Connected Drive portal is possible -> there are issues every now and then lately to connect to that portal and the new error message makes it more clear that it's a connection issue and not an issue of the HA component
  • Added 2 functions so no access to private attributes is needed anymore (fixes this long outstanding request)
  • Changed some logic to vehicle.drive_train_attributes and vehicle.available_attributes

In HA

  • Added a check for sensors and binary_sensors to only add entities if these are actually supported via vehicle.available_attributes. This avoids creating entities which are not available in the BMW Connected Drive portal and that give errors when updating these.
  • Added icons for the binary_sensors as there are some cool car related mdi-icons added lately.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#

Example entry for configuration.yaml (if applicable):

bmw_connected_drive:
  name_of_car:
    username: USERNAME_BMW_CONNECTED_DRIVE
    password: PASSWORD_BMW_CONNECTED_DRIVE
    region: one of "north_america", "china" , "rest_of_world"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Dev automation moved this from Needs review to Reviewer approved Aug 21, 2019

@pvizeli pvizeli merged commit 38ce403 into home-assistant:dev Aug 21, 2019

9 checks passed

CI Build #20190820.49 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Aug 21, 2019

@gerard33 gerard33 deleted the gerard33:bimmer_updates branch Aug 21, 2019

@lock lock bot locked and limited conversation to collaborators Aug 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.