Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for warning attributes to Homematic IP Cloud #26103

Merged
merged 2 commits into from Aug 21, 2019

Conversation

@SukramJ
Copy link
Contributor

commented Aug 21, 2019

Description:

This PR adds warning attributs (overheated, overloaded and undervoltaged) to HmIP entities.
This warnings are also displayed with an alert icon.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.
  • I have followed the development checklist

@project-bot project-bot bot added this to Needs review in Dev Aug 21, 2019

@SukramJ SukramJ changed the title Add supported for warning attributes to Homematic IP Cloud Add support for warning attributes to Homematic IP Cloud Aug 21, 2019

Dev automation moved this from Needs review to Review in progress Aug 21, 2019

@SukramJ SukramJ force-pushed the SukramJ:HmIP-OptionalFeatures branch from 8ec428b to d3262a0 Aug 21, 2019

Dev automation moved this from Review in progress to Reviewer approved Aug 21, 2019

@MartinHjelmare
Copy link
Member

left a comment

Looks good!

@MartinHjelmare MartinHjelmare merged commit f80c9c9 into home-assistant:dev Aug 21, 2019

11 checks passed

CI Build #20190821.17 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 38ce403...855417c
Details
codecov/project 94% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 21, 2019

@SukramJ SukramJ deleted the SukramJ:HmIP-OptionalFeatures branch Aug 21, 2019

@lock lock bot locked and limited conversation to collaborators Aug 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.