Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFi config entry options #26113

Merged
merged 6 commits into from Aug 21, 2019

Conversation

@Kane610
Copy link
Contributor

commented Aug 21, 2019

Breaking Change:

Description:

Allow configuration of UniFi integration options from GUI

  • Don't track clients
  • Don't track devices
  • Don't track wired clients
  • Detection time

Import configuration.yaml to new options

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Kane610 added 2 commits Aug 16, 2019
Add UniFi config entry options
Allow configuration.yaml options to be imported to new options

@project-bot project-bot bot added this to Needs review in Dev Aug 21, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

So here is a thing that is bothering me with the way we use config flow options here. It seems like Unifi is implementing their own version of "disabled" here. It is not passing wired clients to async_add_entities if the options say so.

However, that means that they also never get added to the entity registry where they could be individually be enabled, if the user would want so.

I think that it might make more sense that if one disables wired clients in options, that Unifi updates the entity registry and marks all wired clients as disabled.

@balloob

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Maybe I'm overthinking this, and maybe it's fine to have a double mechanism. But I feel like we're building out all these disable things, just to not use it? 🤔

@Kane610

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

@balloob that's what I want to fix, as I mentioned on discord; I want to get the reload in for this beta but in a separate PR

@Kane610

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

As soon as I this gets the green light and I've fixed comments + tests I'll jump on reworking to use disabled

Dev automation moved this from Needs review to Reviewer approved Aug 21, 2019

@Kane610 Kane610 self-assigned this Aug 21, 2019

Kane610 added 3 commits Aug 21, 2019

@Kane610 Kane610 merged commit 588eac8 into home-assistant:dev Aug 21, 2019

10 of 11 checks passed

codecov/patch 89.28% of diff hit (target 94%)
Details
CI Build #20190821.49 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 21, 2019

@Kane610 Kane610 deleted the Kane610:unifi-config-entry-options branch Aug 21, 2019

@lock lock bot locked and limited conversation to collaborators Aug 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.