Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ID from groups for Homematic IP Cloud #26114

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@SukramJ
Copy link
Contributor

commented Aug 21, 2019

Description:

This PR remove the id attribute for groups, because groups don't have device id/sgtin, just an ugly uuid that is referenced no where else.
image

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@SukramJ

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

Hi @sander76,
you added the id attribute for all devices a few days before. I'd like to remove this attribute for groups only, because it is just an uuid.

I hope you agree.

BR
Markus

@SukramJ SukramJ closed this Aug 21, 2019

Dev automation moved this from Needs review to Cancelled Aug 21, 2019

@SukramJ SukramJ reopened this Aug 21, 2019

Dev automation moved this from Cancelled to Needs review Aug 21, 2019

@sander76

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Fine by me.

@balloob balloob merged commit 95f660f into home-assistant:dev Aug 21, 2019

12 checks passed

CI Build #20190821.38 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 39d62b4...e7f7efa
Details
codecov/project 94% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Needs review to Done Aug 21, 2019

@SukramJ SukramJ deleted the SukramJ:HmIP_FixGrouID branch Aug 21, 2019

@lock lock bot locked and limited conversation to collaborators Aug 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.