Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistics sensors respect given name #26119

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@frenck
Copy link
Member

commented Aug 21, 2019

Breaking Change:

The names of statistics sensor no longer get mean or count appended automatically, respecting the name configured by the user. If you use this integration, this name change will affect the name of the entity.

Description:

The statistics sensor, appends mean or count to the name, while it should respect the name given by the user.

Related issue (if applicable): fixes #26116

Pull request with documentation for home-assistant.io (if applicable): Not needed

Example entry for configuration.yaml (if applicable):

- platform: statistics
  name: 'MiAP2 PSI Stat'
  entity_id: sensor.mi_ap2_aqi

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Dev automation moved this from Needs review to Reviewer approved Aug 21, 2019

@balloob balloob merged commit 12f964c into dev Aug 21, 2019

9 of 12 checks passed

CI Build #20190821.58 failed
Details
CI (Tests PyTest Python36) Tests PyTest Python36 failed
Details
CI (Tests PyTest Python37) Tests PyTest Python37 failed
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94%)
Details
codecov/project 94% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 21, 2019

@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0158 branch Aug 21, 2019

@lock lock bot locked and limited conversation to collaborators Aug 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.