Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitt device_state_attributes between device and group for Homematic IP Cloud #26137

Merged
merged 2 commits into from Aug 22, 2019

Conversation

@SukramJ
Copy link
Contributor

commented Aug 22, 2019

Description:

Splitt device_state_attributes between device and group for Homematic IP Cloud.

#26086 added ID/SGTIN
#26114 removes ID/SGTIN for groups
This PR removes the ID/SGTIN for the "virtual device" Access Point that also only contains a useless uuid.

device_state_attributes are now explicitly added for groups and devices.
The Access Point has its own device_state_attributes.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@SukramJ

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

Please add this to next beta.

@balloob balloob added this to the 0.98 milestone Aug 22, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 22, 2019

@balloob balloob merged commit 82b1b10 into home-assistant:dev Aug 22, 2019

9 checks passed

CI Build #20190822.25 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Aug 22, 2019

@SukramJ SukramJ deleted the SukramJ:HmIP-FixDSA branch Aug 22, 2019

balloob added a commit that referenced this pull request Aug 23, 2019
Splitt device_state_attributes between device and group for Homematic…
… IP Cloud (#26137)

* splitt device_state_attributes between device and group

* readd device_state_attributes for access point

@lock lock bot locked and limited conversation to collaborators Aug 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.