Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log warning if disabled entities receive updates. #26143

Merged
merged 3 commits into from Aug 22, 2019

Conversation

@balloob
Copy link
Member

commented Aug 22, 2019

Description:

Most integrations cannot deal with entity disabling, and will probably end up incorrectly pushing updates to the entity.

This PR will ignore state updates for disabled entities and will trigger a one time warning per entity that they should not have been updated.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.98 milestone Aug 22, 2019

@balloob balloob requested a review from home-assistant/core as a code owner Aug 22, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 22, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 22, 2019

@balloob balloob merged commit aa56b4d into dev Aug 22, 2019

11 checks passed

CI Build #20190822.50 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94%)
Details
codecov/project 94% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 22, 2019

@delete-merged-branch delete-merged-branch bot deleted the test-writing-disabled branch Aug 22, 2019

balloob added a commit that referenced this pull request Aug 23, 2019
Log warning if disabled entities receive updates. (#26143)
* Log warning if disabled entities receive updates.

* Fix test

* Always set entity ID on disabled entities

@lock lock bot locked and limited conversation to collaborators Aug 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.