Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump androidtv to 0.0.24 #26158

merged 2 commits into from Aug 23, 2019


Copy link

commented Aug 23, 2019


Bump androidtv to 0.0.24.

  • Fixes #26125 (bad unique ID for Android TV)
  • This removes 'stopped' as a valid state for the 'state_detection_rules' config parameter -- it would have caused an error anyways if it was used.
  • This also adds the unique_id property for Fire TV devices, not just Android TV devices.

Related issue (if applicable): #26125

Pull request with documentation for (if applicable): TODO


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

@project-bot project-bot bot added this to Needs review in Dev Aug 23, 2019

@JeffLIrion JeffLIrion changed the title Androidtv bump Bump androidtv to 0.0.24 Aug 23, 2019

@pvizeli pvizeli merged commit 55031e6 into home-assistant:dev Aug 23, 2019

12 checks passed

CI Build #20190823.5 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing f704a8e...d208d3e
codecov/project 94% (target 90%)
docs-missing Documentation ok.

Dev automation moved this from Needs review to Done Aug 23, 2019

@pvizeli pvizeli added this to the 0.98 milestone Aug 23, 2019

@lock lock bot locked and limited conversation to collaborators Aug 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.