Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyheos to 0.6.0 #26191

Merged
merged 1 commit into from Aug 25, 2019

Conversation

@andrewsayre
Copy link
Member

commented Aug 25, 2019

Description:

Updates pyheos to latest version to fix an internal issue with playlists. This version also supports the latest HEOS CLI spec (v1.14) and encapsulates communication exceptions into a new library base exception class to minimize leaking details of the internal implementation.

Related issue (if applicable): fixes #24701

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@andrewsayre andrewsayre added this to the 0.98 milestone Aug 25, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 25, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 25, 2019

@pvizeli pvizeli merged commit 7bfb365 into dev Aug 25, 2019

12 checks passed

CI Build #20190825.3 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.02%)
Details
codecov/project 94.02% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 25, 2019

@delete-merged-branch delete-merged-branch bot deleted the bump_pyheos branch Aug 25, 2019

balloob added a commit that referenced this pull request Aug 26, 2019

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.