Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pyhaversion to 3.1.0 #26232

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@fabaff
Copy link
Member

commented Aug 27, 2019

Description:

Changelog: https://github.com/ludeeus/pyhaversion/releases/tag/3.1.0

Related issue (if applicable): fixes #26213

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: version
    source: haio
  - platform: version
    source: docker

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
@andrewsayre
Copy link
Member

left a comment

It looks like tests could be added/improved.

Dev automation moved this from Needs review to Reviewer approved Aug 27, 2019

@pvizeli pvizeli added this to the 0.98.3 milestone Sep 3, 2019

@pvizeli pvizeli merged commit 245450a into dev Sep 3, 2019

11 of 12 checks passed

codecov/patch 50% of diff hit (target 94.02%)
Details
CI Build #20190827.28 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.02% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Sep 3, 2019

@delete-merged-branch delete-merged-branch bot deleted the upgrade-pyhaversion branch Sep 3, 2019

balloob added a commit that referenced this pull request Sep 4, 2019
@balloob balloob referenced this pull request Sep 4, 2019

@lock lock bot locked and limited conversation to collaborators Sep 4, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5 participants
You can’t perform that action at this time.