Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 0.98: Don't update disabled entities (Homematic IP Cloud) #26236

Merged
merged 4 commits into from Aug 28, 2019

Conversation

@SukramJ
Copy link
Contributor

commented Aug 27, 2019

Description:

This PR prevents that disabled entities receive updates.
This PR should be added to 0.98 Milestone
It's related to #26143

The enabled property was added to entity.py to simplify access to enabled/disabled state.
This should be in compliance with (https://github.com/home-assistant/architecture):** home-assistant/architecture/issues/276

Pull request with documentation for developers.home-assistant: home-assistant/developers.home-assistant#310

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

Dev automation moved this from Needs review to Reviewer approved Aug 27, 2019

@SukramJ SukramJ requested a review from home-assistant/core as a code owner Aug 27, 2019

@SukramJ

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

Hi @MartinHjelmare can you please have alook at this PR.
It needs core review and it is a candidate for 0.98.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

I'm not core. 😄

@balloob

@SukramJ

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

But thanks for watching.

@balloob balloob merged commit cf3bb30 into home-assistant:dev Aug 28, 2019

9 checks passed

CI Build #20190828.42 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Aug 28, 2019

@SukramJ

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

Please add this PR to 0.98.1 to avoid messages by #26143

@SukramJ SukramJ deleted the SukramJ:HmIP-FixEntityDisabled branch Aug 28, 2019

@balloob balloob added this to the 0.98.1 milestone Aug 29, 2019

balloob added a commit that referenced this pull request Aug 29, 2019
Fix for 0.98: Don't update disabled entities (Homematic IP Cloud) (#2…
…6236)

* Homematic IP Cloud Fix: Don't update disabled entities

* Added enabled to entity.py

* Update test for enabled

* Update entity.py
@balloob balloob referenced this pull request Aug 29, 2019
KJonline added a commit to Rendili/home-assistant that referenced this pull request Aug 29, 2019
Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into hive-splitfiles-testing

* 'dev' of https://github.com/home-assistant/home-assistant: (550 commits)
  UniFi - dont schedule updates on disabled entities (home-assistant#26278)
  Fix missing DarkSky mdi icon (home-assistant#26274)
  Fix partly cloudy (home-assistant#26277)
  Fix ZHA state restore by always restoring last seen on devices (home-assistant#26271)
  Update sensor.py (home-assistant#26209)
  Add translations
  Clean up HEOS strings (home-assistant#26242)
  Add two new methods to the OpenUV component that consume only a singl… (home-assistant#26207)
  Bump androidtv to 0.0.25 and add tests (home-assistant#26202)
  Velbus config entries remove decorator (home-assistant#26256)
  Updated frontend to 20190828.0
  Fix for 0.98: Don't update disabled entities (Homematic IP Cloud) (home-assistant#26236)
  Update translations
  Enable cert_expiry config entries  (home-assistant#25624)
  Fix WWLLN entity management (home-assistant#26250)
  SMA beta fix home-assistant#26225 (home-assistant#26244)
  Cleanup strings (home-assistant#26243)
  Bump dependency to add PLAY_STATE_STOPPED (home-assistant#26239)
  deCONZ normalizes cover values to follow zigbee spec (home-assistant#26240)
  Remove throttle from update (home-assistant#26216)
  ...

# Conflicts:
#	homeassistant/components/hive/__init__.py
#	homeassistant/components/hive/binary_sensor.py
#	homeassistant/components/hive/light.py
#	homeassistant/components/hive/sensor.py
#	homeassistant/components/hive/switch.py

@lock lock bot locked and limited conversation to collaborators Aug 30, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5 participants
You can’t perform that action at this time.