Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deCONZ normalizes cover values to follow zigbee spec #26240

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@Kane610
Copy link
Contributor

commented Aug 27, 2019

Breaking Change:

Description:

Apparently deCONZ normalises cover values to follow Zigbee spec

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@Kane610 Kane610 self-assigned this Aug 27, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 27, 2019

@Kane610 Kane610 added this to the 0.98 milestone Aug 27, 2019

@Kane610 Kane610 merged commit 1f2e0d3 into home-assistant:dev Aug 27, 2019

12 checks passed

CI Build #20190827.42 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.02%)
Details
codecov/project 94.02% (target 90%)
Details
docs-missing Documentation ok.

Dev automation moved this from Needs review to Done Aug 27, 2019

@Kane610 Kane610 deleted the Kane610:deconz-ikea-cover-improvement branch Aug 27, 2019

@lock lock bot locked and limited conversation to collaborators Aug 28, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.