Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transport data from maps.yandex.ru api #26252

Merged
merged 19 commits into from Sep 19, 2019

Conversation

@rishatik92
Copy link
Contributor

commented Aug 28, 2019

Breaking Change:

Description:

This feature allow to obtain bus departure time at transport stops in many russian cities

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable):
home-assistant/home-assistant.io#10375

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: yandex_transport
    stop_id: 9639579

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

Hi @rishatik92,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@rishatik92

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

Hi all.
Feature was developed in the image dublin_bus_transport (https://www.home-assistant.io/components/dublin_bus_transport/)

@homeassistant homeassistant added cla-signed and removed cla-needed labels Aug 28, 2019
Dev automation moved this from Needs review to Review in progress Aug 31, 2019
@MartinHjelmare MartinHjelmare changed the title adding feature obtaining Moscow transport data from maps.yandex.ru api Add Moscow transport data from maps.yandex.ru api Aug 31, 2019
Copy link
Member

left a comment

Please add a simple docstring to the package __init__.py module too.

Copy link
Member

left a comment

Please add the device_class property to the entity and return "timestamp".

https://developers.home-assistant.io/docs/en/entity_sensor.html#available-device-classes

rishatik92 added 2 commits Sep 1, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

File CODEOWNERS is not up to date. Please run python3 -m script.hassfest and commit the changes.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

Also run script/gen_requirements_all.py and commit the changes.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

Please also update .coveragerc to exclude this integration.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

These instructions were in the PR template before you removed them.

https://github.com/home-assistant/home-assistant/blob/dev/.github/PULL_REQUEST_TEMPLATE.md

@frenck

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

⚠️ I was unable to find a documentation PR (matching this code change) in our documentation repository.

Please, update the documentation and open a PR for it (be sure to create a documentation PR against the next branch) and link 🔗 this PR and the new documentation PR by mentioning the link to the PR's in both openings posts/descriptions.

🏷 I am adding the docs-missing label until this has been resolved.

@frenck frenck added the docs-missing label Sep 3, 2019
@rishatik92 rishatik92 changed the title Add Moscow transport data from maps.yandex.ru api Add transport data from maps.yandex.ru api Sep 4, 2019
rishatik92 added 2 commits Sep 18, 2019
@rishatik92 rishatik92 requested a review from MartinHjelmare Sep 19, 2019
@rishatik92 rishatik92 requested a review from MartinHjelmare Sep 19, 2019
@rishatik92 rishatik92 requested a review from MartinHjelmare Sep 19, 2019
Copy link
Member

left a comment

Great!

Dev automation moved this from Review in progress to Reviewer approved Sep 19, 2019
@rishatik92

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2019

Great!

Great thanks to you for the instructions! 😊

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 19, 2019

Can be merged when build passes.

@rishatik92

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2019

Can be merged when build passes.

lets do it!)

@MartinHjelmare MartinHjelmare merged commit 9e2cd51 into home-assistant:dev Sep 19, 2019
11 checks passed
11 checks passed
CI Build #20190919.75 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 33bd9c8...1c98ff1
Details
codecov/project 94% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 19, 2019
pvizeli added a commit that referenced this pull request Sep 20, 2019
This reverts commit 9e2cd51.
pvizeli added a commit that referenced this pull request Sep 20, 2019
This reverts commit 9e2cd51.
KJonline added a commit to KJonline/home-assistant that referenced this pull request Sep 20, 2019
* dev: (167 commits)
  Bump aiowwlln to 2.0.2 (home-assistant#26769)
  ZHA siren and warning device support (home-assistant#26046)
  Add transport data from maps.yandex.ru api (home-assistant#26766)
  Type hint additions (home-assistant#26765)
  Bump openwrt-luci-rpc to version 1.1.1 (home-assistant#26759)
  Revert "Add transport data from maps.yandex.ru api (home-assistant#26252)" (home-assistant#26762)
  [ci skip] Translation update
  Updated frontend to 20190919.0
  deCONZ improve gateway tests (home-assistant#26709)
  Add transport data from maps.yandex.ru api (home-assistant#26252)
  Update codeowners (home-assistant#26733)
  Bump influxdb to 5.2.3 (home-assistant#26743)
  Izone component (home-assistant#24550)
  Bump restrictedpython to 5.0 (home-assistant#26741)
  Bumped version to 0.99.1
  Add Plex config flow support (home-assistant#26548)
  Bump pyobihai to fix issue with user account (home-assistant#26736)
  Bump TRADFRI (home-assistant#26731)
  Encode prometheus metric names per the prom spec (home-assistant#26639)
  Bump aiohttp to 3.6.1 (home-assistant#26739)
  ...
@lock lock bot locked and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.