Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing DarkSky mdi icon #26274

Merged
merged 3 commits into from Aug 29, 2019

Conversation

@mbo18
Copy link
Contributor

commented Aug 29, 2019

Breaking Change:

None

Description:

Fix mdi icon for DarkSky in 0.98. Icon's name has changed from weather-partlycloudy to weather-partly-cloudy

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

  - platform: darksky
    api_key: !secret dark_sky_key
    forecast:
      - 0
    monitored_conditions:
      - icon

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Fix missing DarkSky mdi icon
Fix mdi icon for DarkSky

@mbo18 mbo18 requested a review from fabaff as a code owner Aug 29, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 29, 2019

@@ -46,8 +46,8 @@
"wind": "windy",
"fog": "fog",
"cloudy": "cloudy",
"partly-cloudy-day": "partlycloudy",
"partly-cloudy-night": "partlycloudy",
"partly-cloudy-day": "partly-cloudy",

This comment has been minimized.

Copy link
@balloob

balloob Aug 29, 2019

Member

this is wrong. we still use partlycloudy as our condition

@balloob balloob referenced this pull request Aug 29, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 29, 2019

@balloob balloob added this to the 0.98.1 milestone Aug 29, 2019

@balloob balloob merged commit 6a02fd5 into home-assistant:dev Aug 29, 2019

1 of 5 checks passed

CI Build #20190829.39 failed
Details
CI (Overview CheckFormat) Overview CheckFormat failed
Details
CI (Overview Lint) Overview Lint failed
Details
CI (Overview Validate) Overview Validate failed
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Aug 29, 2019

balloob added a commit that referenced this pull request Aug 29, 2019
Fix missing DarkSky mdi icon (#26274)
* Fix missing DarkSky mdi icon

Fix mdi icon for DarkSky

* fix icon

* Update weather.py
@balloob

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

Thanks ! Will be in 98.1

KJonline added a commit to Rendili/home-assistant that referenced this pull request Aug 29, 2019
Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into hive-splitfiles-testing

* 'dev' of https://github.com/home-assistant/home-assistant: (550 commits)
  UniFi - dont schedule updates on disabled entities (home-assistant#26278)
  Fix missing DarkSky mdi icon (home-assistant#26274)
  Fix partly cloudy (home-assistant#26277)
  Fix ZHA state restore by always restoring last seen on devices (home-assistant#26271)
  Update sensor.py (home-assistant#26209)
  Add translations
  Clean up HEOS strings (home-assistant#26242)
  Add two new methods to the OpenUV component that consume only a singl… (home-assistant#26207)
  Bump androidtv to 0.0.25 and add tests (home-assistant#26202)
  Velbus config entries remove decorator (home-assistant#26256)
  Updated frontend to 20190828.0
  Fix for 0.98: Don't update disabled entities (Homematic IP Cloud) (home-assistant#26236)
  Update translations
  Enable cert_expiry config entries  (home-assistant#25624)
  Fix WWLLN entity management (home-assistant#26250)
  SMA beta fix home-assistant#26225 (home-assistant#26244)
  Cleanup strings (home-assistant#26243)
  Bump dependency to add PLAY_STATE_STOPPED (home-assistant#26239)
  deCONZ normalizes cover values to follow zigbee spec (home-assistant#26240)
  Remove throttle from update (home-assistant#26216)
  ...

# Conflicts:
#	homeassistant/components/hive/__init__.py
#	homeassistant/components/hive/binary_sensor.py
#	homeassistant/components/hive/light.py
#	homeassistant/components/hive/sensor.py
#	homeassistant/components/hive/switch.py
@Mariusthvdb

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

cool. since this is now fixed in the backend, will it be available for the other weather integrations also?

to the point: can we do this now:

      - tab:
          'weer_klimaat':
            icon: >
              var weer = entity['weather.woensdrecht'].state;
              'mdi:weather-' + weer;

see: https://community.home-assistant.io/t/error-in-condition-classes-buienradar/132804?u=mariusthvdb

@balloob balloob referenced this pull request Aug 29, 2019
@MatthewFlamm

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

@Mariusthvdb These fixes were all for sensors not for weather platforms. The weather condition is still partlycloudy that maps to this icon. See here for the mapping on the frontend.

https://github.com/home-assistant/home-assistant-polymer/blob/a042cd2d48ae2c6f03fdae1c9c30cdfa1d7b6b28/src/cards/ha-weather-card.js#L288

@Mariusthvdb

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

check, I am aware of that, hence my question. It's an obvious inconsistency.

This would seem a great time to adjust both sensors and weather components all to use the mdi naming.
Also, it would give the opportunity to add the -day and -night variations. So eg we don't see a mdi:sun during a clear-night ;-)

btw, noticed OWM wasn't changed yet

@lock lock bot locked and limited conversation to collaborators Aug 31, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5 participants
You can’t perform that action at this time.