Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose current direction properly on state machine #26298

Merged
merged 2 commits into from Sep 2, 2019

Conversation

@balloob
Copy link
Member

commented Aug 30, 2019

Description:

There was a bug in prop_to_attr mapping, causing fan entity to expose self.direction instead of self.current_direction to the state machine. This was also incorrectly implemented in the demo.

I thought about just changing it all to self.direction, but that would be a breaking change, and now it is like documented 馃憤

This fixes it.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Aug 30, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 30, 2019

@balloob balloob referenced this pull request Aug 30, 2019

@balloob balloob force-pushed the fix-direction branch from 4529203 to 5c29685 Aug 31, 2019

@balloob balloob added this to the 0.98.2 milestone Aug 31, 2019

@andrewsayre

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

It looks like this line would need to change to use current_direction? Weird it passedin python 3.7?

Edit: So not the test that's the issue, but the fan platform of template is defining self.direction instead of self.current_direction. I've scanned the code base and this was the only other instance I found.

@balloob

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2019

it didn't pass in 3.7 but there is something else odd going on there. Opened #26311 to track it.

Dev automation moved this from Needs review to Reviewer approved Aug 31, 2019

@balloob balloob merged commit aa7513b into dev Sep 2, 2019

9 checks passed

CI Build #20190831.10 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Sep 2, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-direction branch Sep 2, 2019

balloob added a commit that referenced this pull request Sep 2, 2019
Expose current direction properly on state machine (#26298)
* Expose current direction properly on state machine

* Fix template fan
@balloob balloob referenced this pull request Sep 2, 2019

@lock lock bot locked and limited conversation to collaborators Sep 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can鈥檛 perform that action at this time.