Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HEAD and PUT support to webhooks #26299

Merged
merged 1 commit into from Aug 31, 2019

Conversation

@balloob
Copy link
Member

commented Aug 30, 2019

Description:

This adds HEAD and PUT support to webhooks.

HEAD support is needed to allow working with the Trello API, as they do that to verify if an endpoint exists (docs).

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Dev automation moved this from Needs review to Reviewer approved Aug 30, 2019
@balloob balloob force-pushed the webhook-head-put branch from c8c839d to a18cc0f Aug 30, 2019
@andrewsayre andrewsayre merged commit 37a3d5f into dev Aug 31, 2019
11 checks passed
11 checks passed
CI Build #20190830.33 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 182252a...a18cc0f
Details
codecov/project 93.83% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Aug 31, 2019
@delete-merged-branch delete-merged-branch bot deleted the webhook-head-put branch Aug 31, 2019
@lock lock bot locked and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.