Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alexa bad temp sensors #26307

Merged
merged 1 commit into from Aug 31, 2019

Conversation

@balloob
Copy link
Member

commented Aug 31, 2019

Description:

Catch invalid values being cast to floats for Alexa temperatures.

Related issue (if applicable): fixes #24409

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.98.2 milestone Aug 31, 2019

@project-bot project-bot bot added this to Needs review in Dev Aug 31, 2019

Dev automation moved this from Needs review to Reviewer approved Aug 31, 2019

@andrewsayre andrewsayre merged commit 46b5b0c into dev Aug 31, 2019

10 checks passed

CI Build #20190831.1 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 31, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-alexa-temp-sensors branch Aug 31, 2019

@lock lock bot locked and limited conversation to collaborators Sep 1, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.