Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race during initial Sonos group construction #26371

Merged
merged 2 commits into from Sep 3, 2019

Conversation

@amelchio
Copy link
Contributor

commented Sep 3, 2019

Description:

When adding a player we must rebuild all groups because the new player could be part of an existing group. This change moves the rebuilding of groups to after an entity has been appended to our local inventory.

This avoids 2+ players rebuilding groups with each not yet knowing about the other.

Related issue (if applicable): fixes #26326

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@amelchio amelchio added this to the 0.98.3 milestone Sep 3, 2019

@project-bot project-bot bot added this to Needs review in Dev Sep 3, 2019

Dev automation moved this from Needs review to Review in progress Sep 3, 2019

Dev automation moved this from Review in progress to Reviewer approved Sep 3, 2019

@pvizeli pvizeli merged commit 3534b8a into home-assistant:dev Sep 3, 2019

9 checks passed

CI Build #20190903.13 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Sep 3, 2019

balloob added a commit that referenced this pull request Sep 4, 2019
Fix race during initial Sonos group construction (#26371)
* Fix race during initial Sonos group construction

* Update homeassistant/components/sonos/media_player.py
@balloob balloob referenced this pull request Sep 4, 2019

@lock lock bot locked and limited conversation to collaborators Sep 4, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5 participants
You can’t perform that action at this time.