Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Airly integration #26375

Merged
merged 42 commits into from Oct 4, 2019

Conversation

@bieniu
Copy link
Contributor

bieniu commented Sep 3, 2019

Description:

Airly, new integration that shows air quality data in Poland, Germany and UK from airly.eu

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10285

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
bieniu added 2 commits Sep 3, 2019
Copy link
Member

frenck left a comment

You need to add unit tests for the config flow, that is a requirement for using it.

@bieniu bieniu referenced this pull request Sep 3, 2019
2 of 2 tasks complete
@frenck frenck removed the docs-missing label Sep 3, 2019
homeassistant/components/airly/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/airly/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/airly/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/airly/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/airly/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/airly/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/airly/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/airly/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/airly/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/airly/sensor.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Sep 3, 2019
@bieniu bieniu changed the title Add Airly integration WIP: Add Airly integration Sep 3, 2019
bieniu added 4 commits Sep 6, 2019
@bieniu bieniu changed the title WIP: Add Airly integration Add Airly integration Sep 14, 2019
name = config_entry.data[CONF_NAME]
latitude = config_entry.data[CONF_LATITUDE]
longitude = config_entry.data[CONF_LONGITUDE]
language = config_entry.data[CONF_LANGUAGE]

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Oct 2, 2019

Member

We need to remove his option. I've checked with @balloob and we don't allow language options per integration. We don't have a solution for this kind of translation at the moment.

I'm sorry I didn't catch this earlier.

This comment has been minimized.

Copy link
@bieniu

bieniu Oct 2, 2019

Author Contributor

There is no exception to this rule?

For example Dark Sky sensor has language as an option https://www.home-assistant.io/integrations/darksky/#language

This comment has been minimized.

Copy link
@bieniu

bieniu Oct 2, 2019

Author Contributor

Or maybe integration could read user's language from hass?

Dev automation moved this from Reviewer approved to Review in progress Oct 2, 2019
@project-bot project-bot bot moved this from Review in progress to Second opinion wanted in Dev Oct 2, 2019
@bieniu bieniu requested a review from MartinHjelmare Oct 2, 2019
Copy link
Member

MartinHjelmare left a comment

Thanks!

Dev automation moved this from Second opinion wanted to Reviewer approved Oct 2, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Oct 2, 2019

Test failure seems unrelated.

@bieniu

This comment has been minimized.

Copy link
Contributor Author

bieniu commented Oct 2, 2019

Local tests with tox for airly/test_config_flow.py passed without errors.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Oct 2, 2019

Please rebase on latest dev branch to let the build pass.

Rebase
@bieniu

This comment has been minimized.

Copy link
Contributor Author

bieniu commented Oct 2, 2019

Done

Copy link
Member

MartinHjelmare left a comment

Sorry, noticed that coverage wasn't 100%.

tests/components/airly/test_config_flow.py Outdated Show resolved Hide resolved
Dev automation moved this from Reviewer approved to Review in progress Oct 2, 2019
@bieniu bieniu requested a review from MartinHjelmare Oct 3, 2019
Copy link
Member

MartinHjelmare left a comment

Great! Just some small style things.

tests/components/airly/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/airly/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/airly/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/airly/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/airly/test_config_flow.py Outdated Show resolved Hide resolved
bieniu added 2 commits Oct 3, 2019
Copy link
Member

MartinHjelmare left a comment

Nice!

Dev automation moved this from Review in progress to Reviewer approved Oct 3, 2019
@MartinHjelmare MartinHjelmare merged commit 8ba4ee1 into home-assistant:dev Oct 4, 2019
9 checks passed
9 checks passed
CI Build #20191003.27 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Oct 4, 2019
@bieniu

This comment has been minimized.

Copy link
Contributor Author

bieniu commented Oct 4, 2019

@MartinHjelmare Thanks for your help. It was hard lesson for me but I learned a lot.

@lock lock bot locked and limited conversation to collaborators Oct 5, 2019
@bieniu bieniu deleted the bieniu:airly branch Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.