Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state report #26406

merged 2 commits into from Sep 4, 2019


Copy link

commented Sep 3, 2019


The and check was on the wrong if-condition.

Related issue (if applicable): fixes #26355


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.98.3 milestone Sep 3, 2019

@project-bot project-bot bot added this to Needs review in Dev Sep 3, 2019

Dev automation moved this from Needs review to Reviewer approved Sep 4, 2019

Copy link

left a comment

Looks good.

@andrewsayre andrewsayre merged commit 4e2fcdb into dev Sep 4, 2019

10 of 11 checks passed

codecov/patch 50% of diff hit (target 93.98%)
CI Build #20190903.92 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/project 93.98% (target 90%)

Dev automation moved this from Reviewer approved to Done Sep 4, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-state-report-json branch Sep 4, 2019

balloob added a commit that referenced this pull request Sep 4, 2019
Fix state report (#26406)
* Fix state report

* Update test
@balloob balloob referenced this pull request Sep 4, 2019
pgilad added a commit to pgilad/home-assistant that referenced this pull request Sep 4, 2019
Merge branch 'dev' into improve-bluetooth-tracker
* dev: (87 commits)
  Add atome sensor platform (home-assistant#26197)
  Replaces IOError by OSError (home-assistant#26428)
  Entity registry doesn't overwrite with None (home-assistant#24275)
  Add device to mqtt camera (home-assistant#26238)
  Updated frontend to 20190904.0 (home-assistant#26421)
  Add prettier to vscode (home-assistant#26417)
  NSW Rural Fire Service icon for geolocation entities (home-assistant#26416)
  Update azure-pipelines-translation.yml for Azure Pipelines
  [ci skip] Translation update
  Update azure-pipelines-translation.yml for Azure Pipelines
  Update azure-pipelines-translation.yml for Azure Pipelines
  Update azure-pipelines-translation.yml for Azure Pipelines
  Update azure-pipelines-translation.yml for Azure Pipelines
  Bumped version to 0.98.3
  Bump ISY994's PyISY dependency to 1.1.2 (home-assistant#26413)
  Fix state report (home-assistant#26406)
  Update to 0.1.13 (home-assistant#26402)
  Met, check for existing location (home-assistant#26400)
  Allow core config updated (home-assistant#26398)
  Fix race during initial Sonos group construction (home-assistant#26371)

@lock lock bot locked and limited conversation to collaborators Sep 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.