Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Plex server connections #26444

Merged
merged 22 commits into from Sep 5, 2019

Conversation

@jjlawren
Copy link
Contributor

commented Sep 5, 2019

Breaking Change:

Logins using a username/password/servername are no longer supported on the Plex sensor platform. This functionality will be partially restored in followup PRs which add a configuration flow and external authentication.

Description:

First step in using common code between the Plex media_player and sensor platforms. This adds a common class to connect to Plex servers.

This is a smaller part of #26157.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10297

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: plex
    host: 192.168.1.5
    token: abc1234xyz

media_player:
  - platform: plex

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Untested files have been added to .coveragerc.
jjlawren added 2 commits Sep 5, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 5, 2019
jjlawren added 4 commits Sep 5, 2019
@jjlawren jjlawren marked this pull request as ready for review Sep 5, 2019
homeassistant/components/plex/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/plex/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/plex/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/plex/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/plex/server.py Outdated Show resolved Hide resolved
homeassistant/components/plex/server.py Outdated Show resolved Hide resolved
homeassistant/components/plex/sensor.py Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Sep 5, 2019
jjlawren and others added 11 commits Sep 5, 2019
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
…ant into plex_central_server
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
jjlawren added 3 commits Sep 5, 2019
Copy link
Member

left a comment

Great!

Dev automation moved this from Review in progress to Reviewer approved Sep 5, 2019
@dshokouhi

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

Should we also consider changing the configuration to being included under the plex: domain? I know might be out of scope of this PR but I figured this integration should become like the others where it discovers the media player and sensor after accessing the server.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

Yeah, we're talking about that. But it's not for this PR.

@jjlawren jjlawren referenced this pull request Sep 5, 2019
2 of 2 tasks complete
@MartinHjelmare MartinHjelmare merged commit 2cd845f into home-assistant:dev Sep 5, 2019
11 checks passed
11 checks passed
CI Build #20190905.35 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project 93.99% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 5, 2019
@jjlawren jjlawren referenced this pull request Sep 5, 2019
4 of 5 tasks complete
@jjlawren jjlawren deleted the jjlawren:plex_central_server branch Sep 5, 2019
@lock lock bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.