Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light platform to iaqualink integration #26484

Merged
merged 3 commits into from Sep 9, 2019

Conversation

@flz
Copy link
Contributor

commented Sep 6, 2019

Description:

Add light platform to iaqualink integration. Supports brightness and effects when available.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10165 (documentation is for complete integration, only climate platform has landed yet).

Example entry for configuration.yaml (if applicable):

iaqualink:
    username: USERNAME
    password: PASSWORD

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Sep 6, 2019
@MartinHjelmare MartinHjelmare changed the title Add light platform to iaqualink integration. Add light platform to iaqualink integration Sep 6, 2019
Dev automation moved this from Needs review to Review in progress Sep 6, 2019
homeassistant/components/iaqualink/light.py Outdated Show resolved Hide resolved
homeassistant/components/iaqualink/light.py Outdated Show resolved Hide resolved
homeassistant/components/iaqualink/light.py Outdated Show resolved Hide resolved
homeassistant/components/iaqualink/light.py Outdated Show resolved Hide resolved
homeassistant/components/iaqualink/light.py Outdated Show resolved Hide resolved
homeassistant/components/iaqualink/light.py Outdated Show resolved Hide resolved
@frenck frenck added docs-missing and removed docs-missing labels Sep 9, 2019
flz added 3 commits Sep 6, 2019
@flz flz force-pushed the flz:iaqualink-light branch from b8f6176 to ed1ce0c Sep 9, 2019
Dev automation moved this from Review in progress to Reviewer approved Sep 9, 2019
Copy link
Member

left a comment

Great!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Can be merged when build passes.

@flz flz referenced this pull request Sep 9, 2019
2 of 2 tasks complete
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Let's make any further changes, as discussed, in another PR.

@MartinHjelmare MartinHjelmare merged commit 3c629db into home-assistant:dev Sep 9, 2019
11 checks passed
11 checks passed
CI Build #20190909.35 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing f167914...ed1ce0c
Details
codecov/project 94.01% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 9, 2019
@flz flz deleted the flz:iaqualink-light branch Sep 10, 2019
@lock lock bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.