Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sinch integration (notify component) #26502

Merged
merged 15 commits into from Oct 18, 2019

Conversation

@bendikrb
Copy link
Contributor

bendikrb commented Sep 7, 2019

Description:

Provides integration with the Sinch API.

**Pull request with documentation for home-assistant.io

Example entry for configuration.yaml (if applicable):

notify:
  - platform: sinch
    name: Sinch
    api_key: SINCH_API_KEY
    service_plan_id: SINCH_SERVICE_PLAN_ID
    sender: Home Assistant

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link
Contributor

homeassistant commented Sep 7, 2019

Hi @bendikrb,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant

This comment has been minimized.

Copy link
Contributor

homeassistant commented Sep 7, 2019

Hi @bendikrb,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@bendikrb bendikrb changed the title Added sinch integration (notify component) Add sinch integration (notify component) Sep 7, 2019
@homeassistant homeassistant added cla-signed and removed cla-needed labels Sep 7, 2019
Copy link
Member

andrewsayre left a comment

Welcome and thanks for your contribution! This looks pretty good -- please see the comments below and let me know if you have any questions.

homeassistant/components/sinch/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/sinch/notify.py Show resolved Hide resolved
homeassistant/components/sinch/notify.py Outdated Show resolved Hide resolved
homeassistant/components/sinch/notify.py Outdated Show resolved Hide resolved
homeassistant/components/sinch/notify.py Outdated Show resolved Hide resolved
homeassistant/components/sinch/notify.py Outdated Show resolved Hide resolved
homeassistant/components/sinch/notify.py Outdated Show resolved Hide resolved
homeassistant/components/sinch/notify.py Outdated Show resolved Hide resolved
homeassistant/components/sinch/notify.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Sep 8, 2019
@andrewsayre

This comment has been minimized.

Copy link
Member

andrewsayre commented Sep 8, 2019

FYI, I've added the docs-missing label while you work on creating the documentation for your new integration.

bendikrb and others added 5 commits Sep 12, 2019
Co-Authored-By: Andrew Sayre <6730289+andrewsayre@users.noreply.github.com>
Co-Authored-By: Andrew Sayre <6730289+andrewsayre@users.noreply.github.com>
Co-Authored-By: Andrew Sayre <6730289+andrewsayre@users.noreply.github.com>
bendikrb added a commit to bendikrb/home-assistant.io that referenced this pull request Sep 17, 2019
bendikrb added 2 commits Sep 17, 2019
@bendikrb bendikrb referenced this pull request Sep 17, 2019
2 of 2 tasks complete
@bendikrb bendikrb requested a review from andrewsayre Sep 17, 2019
bendikrb added 4 commits Sep 17, 2019
@frenck frenck removed the docs-missing label Sep 17, 2019
@balloob balloob merged commit 9625e04 into home-assistant:dev Oct 18, 2019
11 checks passed
11 checks passed
CI Build #20191003.3 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 743cb84...174b61e
Details
codecov/project 94.33% (target 90%)
Details
Dev automation moved this from Review in progress to Done Oct 18, 2019
@lock lock bot locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants
You can’t perform that action at this time.