Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensor platform to iaqualink component #26544

Merged
merged 2 commits into from Sep 10, 2019

Conversation

@flz
Copy link
Contributor

commented Sep 9, 2019

Description:

Add sensor platform support to iaqualink integration.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10334

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@flz

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

Documentation to follow.

homeassistant/components/iaqualink/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/iaqualink/sensor.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Sep 9, 2019
Copy link
Member

left a comment

Nice!

Dev automation moved this from Review in progress to Reviewer approved Sep 9, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Can be merged when build passes and a docs PR is linked in the PR description.

@flz

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

Thanks! Waiting for home-assistant/home-assistant.io#10165 to land so I can submit the doc PR for this platform.

@flz flz referenced this pull request Sep 10, 2019
0 of 2 tasks complete
@flz

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

Documentation PR at home-assistant/home-assistant.io#10334.

@MartinHjelmare MartinHjelmare merged commit a7830bc into home-assistant:dev Sep 10, 2019
11 checks passed
11 checks passed
CI Build #20190909.61 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3c629db...8feee8d
Details
codecov/project 94.01% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 10, 2019
@flz flz deleted the flz:iaqualink-sensor branch Sep 10, 2019
KJonline added a commit to KJonline/home-assistant that referenced this pull request Sep 11, 2019
* dev: (42 commits)
  Remove default host for Plex config (home-assistant#26583)
  Add Obihai integration (home-assistant#26537)
  Add switch platform to iaqualink integration (home-assistant#26545)
  Fix GTFS sensor wrong timezone (home-assistant#26580)
  Make uk_transport sensor timezone/DST aware (home-assistant#26577)
  Updated frontend to 20190911.0 (home-assistant#26578)
  bump dependencies (home-assistant#26576)
  Bump UPC connect / fix auth issue (home-assistant#26570)
  Cleanup stale script stuff (home-assistant#26573)
  Improve startup of devcontainer (home-assistant#26572)
  Ignore test output
  [ci skip] Translation update
  deCONZ device automations (home-assistant#26366)
  Nuki less strict (home-assistant#26542)
  osram cluster (home-assistant#26555)
  fix events for smartthings acceleration cluster (home-assistant#26557)
  Fix tests
  Refactor Cast (home-assistant#26550)
  Add sensor platform to iaqualink component (home-assistant#26544)
  Bump geniushub-client to 0.6.13 (home-assistant#26554)
  ...
@lock lock bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.