Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zha ZCL color loop effect #26549

Merged
merged 6 commits into from Sep 14, 2019

Conversation

@amigan
Copy link
Contributor

commented Sep 10, 2019

Description:

Add support for ZCL lighting color channel loop support.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@amigan amigan requested review from Adminiuga and dmulcahey as code owners Sep 10, 2019
@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Hi @amigan,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@project-bot project-bot bot added this to Needs review in Dev Sep 10, 2019
@homeassistant homeassistant added cla-signed and removed cla-needed labels Sep 10, 2019
@amigan

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

I've tested this with Sylvania SMART+ (current US Osram Lightify?) A19 RGBW bulbs.

amigan added 2 commits Sep 10, 2019
@dmulcahey

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Can you format the code w/ black and update the PR so that it passes CI please?

@Adminiuga

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

@amigan here's some info on installing pre-commit hook https://developers.home-assistant.io/blog/2019/07/31/black.html

@amigan

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

Thank you. I've reformatted.

Dev automation moved this from Needs review to Review in progress Sep 12, 2019
homeassistant/components/zha/light.py Outdated Show resolved Hide resolved
Copy link
Contributor

left a comment

Otherwise looks good and can be merged once comments are addressed.

@amigan amigan requested a review from Adminiuga Sep 14, 2019
Dev automation moved this from Review in progress to Reviewer approved Sep 14, 2019
Copy link
Contributor

left a comment

Good to merge when build passes.

@Adminiuga Adminiuga merged commit bca7363 into home-assistant:dev Sep 14, 2019
11 checks passed
11 checks passed
CI Build #20190914.2 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 6f31c68...81b1d33
Details
codecov/project 94% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 14, 2019
@lock lock bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.