Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move elv integration to component and bump pypca #26552

Merged
merged 6 commits into from Sep 24, 2019

Conversation

@majuss
Copy link
Contributor

commented Sep 10, 2019

Breaking Change:

All config for the ELV/PCA component/integration should be removed and replaced with:

elv:

Optionally the exact port for the serial interface can be specified (default is: /dev/ttyUSB0).

Description:

Corrected the setup of the elv integration and it's switch platform. Bumped pypca to version 0.0.5.

Documentation PR: home-assistant/home-assistant.io#9995

Example entry for configuration.yaml (if applicable):

elv:
  device: '/dev/ttyUSB0'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Sep 10, 2019
@majuss

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

So the black formatter fails again. I fully recreated everything. Here was the old PR: #25539

So I was finally able to check the formatting when I installed black on my local Mac. On my raspberry it won't work at all (fresh raspbian buster installation).

majuss added 2 commits Sep 10, 2019
@pvizeli

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

please rebase

Copy link
Member

left a comment

Is possible to set the property unique_id with a serial number? That would allow changing the name on the frontend.

name = config[CONF_NAME]
usb_device = config[CONF_DEVICE]
if discovery_info is None:
_LOGGER.warning("Please update your config for elv")

This comment has been minimized.

Copy link
@pvizeli

pvizeli Sep 11, 2019

Member

just return, the warning is not needed because the config is also not valid

This comment has been minimized.

Copy link
@majuss

majuss Sep 12, 2019

Author Contributor

The serial number is not transmitted, so we can't use it in any way.

majuss added 2 commits Sep 12, 2019
@majuss

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

If anybody could help me with the CI pipeline I would be really graceful... It now fails at the rpi_gpio module which is not involved in my pr in any way..

@pvizeli

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

You need rebase your code to fix it

Dev automation moved this from Needs review to Reviewer approved Sep 13, 2019
@pvizeli

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

@majuss

This comment has been minimized.

Copy link
Contributor Author

commented Sep 16, 2019

@majuss

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

@pvizeli @MartinHjelmare
Can somebody please merge? Thanks a lot!

@MartinHjelmare MartinHjelmare merged commit 930dadb into home-assistant:dev Sep 24, 2019
12 checks passed
12 checks passed
CI Build #20190916.10 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 6f31c68...bb0a15c
Details
codecov/project 94.01% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 24, 2019
@lock lock bot locked and limited conversation to collaborators Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.