Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zigate to 0.3.0 #26586

Merged
merged 2 commits into from Sep 12, 2019

Conversation

@doudz
Copy link
Contributor

commented Sep 11, 2019

Bump zigate to 0.3.0 (various fixes)

doudz added 2 commits Sep 11, 2019
@doudz doudz requested review from Adminiuga and dmulcahey as code owners Sep 11, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 11, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 11, 2019
@Adminiuga Adminiuga merged commit 3fda07a into home-assistant:dev Sep 12, 2019
10 of 12 checks passed
10 of 12 checks passed
CI Build #20190911.51 failed
Details
CI (FullCheck Pylint) FullCheck Pylint failed
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 182bf1e...80ba0bc
Details
codecov/project 93.97% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 12, 2019
@Adminiuga Adminiuga added this to the 0.99 milestone Sep 12, 2019
@pvizeli

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Please fix the lint. Look like your Zigbee has overwritten a module name?

@pvizeli pvizeli removed this from the 0.99 milestone Sep 12, 2019
@pvizeli

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

#26599

This destroy the lint/build pipelines. I fix that and we can only merge this to beta with the fix above. Ask paulus or something else to merge that correctly into beta, otherwise, it's in next version.

@doudz

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

thank !
I also change my lib to only require Rpi.GPIO when running on Rpi
I will push release 0.3.1 soon

@doudz

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

should be better with #26600

@lock lock bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants
You can’t perform that action at this time.