Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deCONZ - battery sensor instead of battery attribute #26591

Merged
merged 8 commits into from Sep 14, 2019

Conversation

@Kane610
Copy link
Member

commented Sep 11, 2019

Breaking Change:

Standardizes battery sensor unique id to the serial number of device + battery.
Entity attribute battery level will no longer be available, this will instead be exposed as a separate entity just as with remotes previously.

Description:

Move battery attribute to a standalone sensor per physical device

Related issue (if applicable): fixes Kane610/deconz#42

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@Kane610 Kane610 self-assigned this Sep 11, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 11, 2019
@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Sep 12, 2019
@Kane610 Kane610 marked this pull request as ready for review Sep 12, 2019
@MartinHjelmare MartinHjelmare moved this from Incoming to Needs review in Dev Sep 13, 2019
@Kane610 Kane610 force-pushed the Kane610:deconz-battery-sensor branch 2 times, most recently from 7493dc6 to f8a69ac Sep 13, 2019
@Kane610 Kane610 force-pushed the Kane610:deconz-battery-sensor branch from f8a69ac to 005a665 Sep 14, 2019
@Kane610

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2019

@MartinHjelmare any additional comments?

Copy link
Member

left a comment

Looks great!

Dev automation moved this from Needs review to Reviewer approved Sep 14, 2019
@Kane610

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2019

Awesome, thanks @MartinHjelmare

@Kane610 Kane610 merged commit 41c9ed5 into home-assistant:dev Sep 14, 2019
11 checks passed
11 checks passed
CI Build #20190914.58 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 93.98%)
Details
codecov/project 93.98% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 14, 2019
@Kane610 Kane610 deleted the Kane610:deconz-battery-sensor branch Sep 14, 2019
KJonline added a commit to KJonline/home-assistant that referenced this pull request Sep 15, 2019
* dev: (38 commits)
  Fix Environment Canada weather forecast, retain icon_code sensor (home-assistant#26646)
  Rename MockToggleDevice to MockToggleEntity (home-assistant#26644)
  Refactor nzbget to support future platform changes (home-assistant#26462)
  deCONZ - Remove mechanisms to import a configuration from configuration.yaml (home-assistant#26648)
  deCONZ - battery sensor instead of battery attribute (home-assistant#26591)
  Add built in weather to Homematic IP Cloud (home-assistant#26642)
  Move deCONZ services to their own file (home-assistant#26645)
  Add group attribute to Homematic IP Cloud (home-assistant#26618)
  Add iaqualink binary sensor and unique_id (home-assistant#26616)
  zha ZCL color loop effect (home-assistant#26549)
  [ci skip] Translation update
  deCONZ -  create deconz_events through sensor platform (home-assistant#26592)
  Update azure-pipelines-wheels.yml for Azure Pipelines
  Update azure-pipelines-wheels.yml
  Refactor Bluetooth Tracker to async (home-assistant#26614)
  Fix Typo (home-assistant#26612)
  [ci skip] Translation update
  Disable Watson TTS Telemetry (home-assistant#26253)
  Improve bluetooth tracker device code (home-assistant#26067)
  Bump zigpy-zigate to 0.3.1 (home-assistant#26600)
  ...
@lock lock bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.