Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deCONZ - create deconz_events through sensor platform #26592

Merged

Conversation

@Kane610
Copy link
Member

commented Sep 11, 2019

Breaking Change:

Description:

Gateway class shouldn't be responsible for creating deconz_events

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Kane610 added 3 commits Sep 11, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 11, 2019
@Kane610 Kane610 changed the title deCONZ - events created from deconz_events through sensor platform deCONZ - create deconz_events through sensor platform Sep 11, 2019
@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Sep 12, 2019
@Kane610 Kane610 marked this pull request as ready for review Sep 13, 2019
@Kane610 Kane610 merged commit fb1acfc into home-assistant:dev Sep 13, 2019
11 checks passed
11 checks passed
CI Build #20190913.44 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 93.99%)
Details
codecov/project 94% (target 90%)
Details
Dev automation moved this from Incoming to Done Sep 13, 2019
@Kane610 Kane610 deleted the Kane610:deconz-events-created-from-sensors branch Sep 13, 2019
@lock lock bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
2 participants
You can’t perform that action at this time.