Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iaqualink binary sensor and unique_id #26616

Merged
merged 3 commits into from Sep 14, 2019

Conversation

@flz
Copy link
Contributor

commented Sep 13, 2019

Description:

This PR introduces a new binary_sensor platform solving the issue with the freeze_protection sensor not being identified properly.

This also introduces the use of unique_id for all existing platforms to allow future multi-pool support.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10354

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@flz

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2019

@flz

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2019

@MartinHjelmare Is this a worthy 0.99 fix?

Dev automation moved this from Needs review to Review in progress Sep 13, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

No, we won't add it to 0.99 since it's a new platform and new features.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

Why does the entity_id change when we add the unique_id?

@flz

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2019

Why does the entity_id change when we add the unique_id?

I can't seem to reproduce but it was the case yesterday when I overrode unique_id.

I've removed the integration, turned it back on (without unique_id), stopped HA, added unique_id, restarted HA and entity names didn't change this time.

@flz flz force-pushed the flz:iaqualink-binary-sensor branch from d148711 to bf20b4a Sep 13, 2019
Dev automation moved this from Review in progress to Reviewer approved Sep 13, 2019
Copy link
Member

left a comment

Nice!

@MartinHjelmare MartinHjelmare changed the title Add binary_platform to iaqualink integration, add unique_id Add iaqualink binary sensor and unique_id Sep 14, 2019
@MartinHjelmare MartinHjelmare merged commit a71cd6e into home-assistant:dev Sep 14, 2019
11 checks passed
11 checks passed
CI Build #20190913.33 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 7e7ec49...ea867b4
Details
codecov/project 93.99% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 14, 2019
@lock lock bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.