Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group attribute to Homematic IP Cloud #26618

Merged
merged 2 commits into from Sep 14, 2019

Conversation

@SukramJ
Copy link
Contributor

commented Sep 13, 2019

Description:

This PR adds an attribute (is_group) to identify group based entities e.g. for filtering.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
Dev automation moved this from Needs review to Reviewer approved Sep 13, 2019
@MartinHjelmare MartinHjelmare merged commit 1d3f2d2 into home-assistant:dev Sep 14, 2019
11 checks passed
11 checks passed
CI Build #20190913.11 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 7e7ec49...8b573a4
Details
codecov/project 93.99% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 14, 2019
@SukramJ SukramJ deleted the SukramJ:HmIP-isGroup branch Sep 14, 2019
@lock lock bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.