New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak geniushub and bump client to v0.6.26 #26640
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxdavb
changed the title
Tweak geniushub and bump client to v0.6.25
Tweak geniushub and bump client to v0.6.26
Oct 1, 2019
zxdavb
commented
Oct 1, 2019
@MartinHjelmare can we fit this in today? |
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
…to geniushub_tweak
MartinHjelmare
approved these changes
Oct 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Those connecting to a Hub via the v1 API will need to specify a valid MAC address for the hub (see example YAML, below). Those using the v3 API will be unaffected.
This is so that in an upcoming PR, the geniushub entities can be given more appropriate
entity_id
s.Some Sensor entities fro GeniusHub Issues have been renamed, and so will get a new entity ID:
sensor.errors
tosensor.geniushub_errors
sensor.warnings
tosensor.geniushub_warnings
sensor.information
tosensor.geniushub_information
This is to address the issue that (e.g.)
sensor.errors
clearly has the potential to be not unique across thesensors
platform.Description:
device_state_attributes
, e.g.setback
for TRVssnake_case
Refactor (consolidate) by creating GeniusZone, GeniusDevice classes in
__init__.py
and moving code across from climate/water_heater, sensor/binary_sensor.Bumps client to v0.6.26:
logger.warning()
s for persisting Issuesunique_id
The newer client also adds useful data which is not currently part of the (published) v1 API
device.data["_config"]
(e.g. SKU) anddevice.data["_state"]
(e.g. TRV setback)zone.data["_occupied"]
if has a PIR which is not exposed by v1 APIzone.data["_schedule"]["footprint"]["profile"]
(comfort, eco, super-eco)See: manzanotti/geniushub-client@v0.6.13...v0.6.26
Related issue (if applicable): N/A
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10443
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: