Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add built in weather to Homematic IP Cloud #26642

Merged
merged 1 commit into from Sep 14, 2019

Conversation

@SukramJ
Copy link
Contributor

commented Sep 14, 2019

Description:

This PR adds the built in weather functionality.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@project-bot project-bot bot added this to Needs review in Dev Sep 14, 2019
@SukramJ SukramJ changed the title Add build in weather to Homematic IP Cloud Add buildin weather to Homematic IP Cloud Sep 14, 2019
@MartinHjelmare MartinHjelmare changed the title Add buildin weather to Homematic IP Cloud Add builtin weather to Homematic IP Cloud Sep 14, 2019
Copy link
Member

left a comment

Looks good!

Dev automation moved this from Needs review to Reviewer approved Sep 14, 2019
@MartinHjelmare MartinHjelmare changed the title Add builtin weather to Homematic IP Cloud Add built in weather to Homematic IP Cloud Sep 14, 2019
@MartinHjelmare MartinHjelmare merged commit 24f1ff0 into home-assistant:dev Sep 14, 2019
12 checks passed
12 checks passed
CI Build #20190914.34 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 1d3f2d2...b7421f6
Details
codecov/project 94% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 14, 2019
@SukramJ SukramJ deleted the SukramJ:HmIP-simpleWeather branch Sep 14, 2019
KJonline added a commit to KJonline/home-assistant that referenced this pull request Sep 15, 2019
* dev: (38 commits)
  Fix Environment Canada weather forecast, retain icon_code sensor (home-assistant#26646)
  Rename MockToggleDevice to MockToggleEntity (home-assistant#26644)
  Refactor nzbget to support future platform changes (home-assistant#26462)
  deCONZ - Remove mechanisms to import a configuration from configuration.yaml (home-assistant#26648)
  deCONZ - battery sensor instead of battery attribute (home-assistant#26591)
  Add built in weather to Homematic IP Cloud (home-assistant#26642)
  Move deCONZ services to their own file (home-assistant#26645)
  Add group attribute to Homematic IP Cloud (home-assistant#26618)
  Add iaqualink binary sensor and unique_id (home-assistant#26616)
  zha ZCL color loop effect (home-assistant#26549)
  [ci skip] Translation update
  deCONZ -  create deconz_events through sensor platform (home-assistant#26592)
  Update azure-pipelines-wheels.yml for Azure Pipelines
  Update azure-pipelines-wheels.yml
  Refactor Bluetooth Tracker to async (home-assistant#26614)
  Fix Typo (home-assistant#26612)
  [ci skip] Translation update
  Disable Watson TTS Telemetry (home-assistant#26253)
  Improve bluetooth tracker device code (home-assistant#26067)
  Bump zigpy-zigate to 0.3.1 (home-assistant#26600)
  ...
@lock lock bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.